[infinispan-dev] ISPN-8798 ByteString places too strict a constraint on cache name length

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[infinispan-dev] ISPN-8798 ByteString places too strict a constraint on cache name length

Paul Ferraro
Can one of the devs please review this patch?
https://github.com/infinispan/infinispan/pull/5750

The limit of cache names sizes to 127 bytes is too limiting for
hibernate/JPA 2nd level cache deployments, which generate cache names
using fully qualified class names of entity classes, which are user
generated thus can easily exceed 128 bytes (but are far less likely to
exceed 255).  This is exacerbated by the JPA integration, which
additionally appends the deployment name.  We have a long term
solution for this, but in the meantime, the above patch is sufficient
to pass the TCK.

We'll also need a 9.1.6.Final release ASAP, lest we revert back to
Infinispan 8.2.x for WF12, the feature freeze for which is tomorrow
(they are considering this upgrade a feature, given the scope of its
impact).

Thanks,

Paul
_______________________________________________
infinispan-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/infinispan-dev
Reply | Threaded
Open this post in threaded view
|

Re: [infinispan-dev] ISPN-8798 ByteString places too strict a constraint on cache name length

Tristan Tarrant-2
We can cut 9.1.6.Final today.

--
Tristan Tarrant
Infinispan Lead & Data Grid Architect
Red Hat

On 13 Feb 2018 14:21, "Paul Ferraro" <[hidden email]> wrote:
Can one of the devs please review this patch?
https://github.com/infinispan/infinispan/pull/5750

The limit of cache names sizes to 127 bytes is too limiting for
hibernate/JPA 2nd level cache deployments, which generate cache names
using fully qualified class names of entity classes, which are user
generated thus can easily exceed 128 bytes (but are far less likely to
exceed 255).  This is exacerbated by the JPA integration, which
additionally appends the deployment name.  We have a long term
solution for this, but in the meantime, the above patch is sufficient
to pass the TCK.

We'll also need a 9.1.6.Final release ASAP, lest we revert back to
Infinispan 8.2.x for WF12, the feature freeze for which is tomorrow
(they are considering this upgrade a feature, given the scope of its
impact).

Thanks,

Paul
_______________________________________________
infinispan-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/infinispan-dev

_______________________________________________
infinispan-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/infinispan-dev
Reply | Threaded
Open this post in threaded view
|

Re: [infinispan-dev] ISPN-8798 ByteString places too strict a constraint on cache name length

Paul Ferraro
Excellent.  Thanks a million.

On Tue, Feb 13, 2018 at 8:33 AM, Tristan Tarrant <[hidden email]> wrote:

> We can cut 9.1.6.Final today.
>
> --
> Tristan Tarrant
> Infinispan Lead & Data Grid Architect
> Red Hat
>
> On 13 Feb 2018 14:21, "Paul Ferraro" <[hidden email]> wrote:
>>
>> Can one of the devs please review this patch?
>> https://github.com/infinispan/infinispan/pull/5750
>>
>> The limit of cache names sizes to 127 bytes is too limiting for
>> hibernate/JPA 2nd level cache deployments, which generate cache names
>> using fully qualified class names of entity classes, which are user
>> generated thus can easily exceed 128 bytes (but are far less likely to
>> exceed 255).  This is exacerbated by the JPA integration, which
>> additionally appends the deployment name.  We have a long term
>> solution for this, but in the meantime, the above patch is sufficient
>> to pass the TCK.
>>
>> We'll also need a 9.1.6.Final release ASAP, lest we revert back to
>> Infinispan 8.2.x for WF12, the feature freeze for which is tomorrow
>> (they are considering this upgrade a feature, given the scope of its
>> impact).
>>
>> Thanks,
>>
>> Paul
>> _______________________________________________
>> infinispan-dev mailing list
>> [hidden email]
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
> _______________________________________________
> infinispan-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/infinispan-dev